Skip to content

errdoc-gen: validate input arguments - #88

Merged
kennytm merged 4 commits into
masterfrom
kennytm/sanitize-errdoc-gen
Nov 12, 2026
Merged

kennytm merged 4 commits into
masterfrom
kennytm/sanitize-errdoc-gen

Conversation

@kennytm

@kennytm kennytm commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

This comment was marked as resolved.

This comment was marked as resolved.

@kennytm

kennytm commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

randomly picking oncallers having commit access.

PTAL @elsa0520 @YuJuncen @coocood @crazycs520 @shenli

kennytm and others added 3 commits November 12, 2026 13:50
Add import for pingcap/errors for offline test dependencies.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@kennytm
kennytm force-pushed the kennytm/sanitize-errdoc-gen branch from 802f6f2 to 47a666d Compare November 12, 2026 05:50
@kennytm
kennytm requested a balanced review from Copilot November 12, 2026 05:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the changes hardening input validation and failure handling in errdoc-gen.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@kennytm
kennytm merged commit 507e76e into master Nov 12, 2026
1 check passed
@kennytm
kennytm deleted the kennytm/sanitize-errdoc-gen branch November 12, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants